[webkit-reviews] review granted: [Bug 227581] [Model] Restrict IPC calls to ARKit SPI availability and runtime flag : [Attachment 432686] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227581: [Model] Restrict IPC calls to ARKit SPI availability and runtime
flag
https://bugs.webkit.org/show_bug.cgi?id=227581

Attachment 432686: Patch

https://bugs.webkit.org/attachment.cgi?id=432686&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432686
  --> https://bugs.webkit.org/attachment.cgi?id=432686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432686&action=review

> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:59
> +    if (!m_webPageProxy->preferences().modelElementEnabled())
> +	   return;

These could be stronger (like MESSAGE_CHECKs, killing the WP if something
unexpected is happening), but this is certainly better than nothing.