[webkit-reviews] review granted: [Bug 227444] Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread : [Attachment 432384] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted  review:
Bug 227444: Make
LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to
main thread before hopping to processing thread
https://bugs.webkit.org/show_bug.cgi?id=227444

Attachment 432384: Patch

https://bugs.webkit.org/attachment.cgi?id=432384&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432384
  --> https://bugs.webkit.org/attachment.cgi?id=432384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432384&action=review

>>>
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLaye
r.mm:401
>>> +	     m_processingQueue->dispatch([this] {
>> 
>> Why is this safe? What guarantees that |this| is still alive when the lambda
runs?
> 
> We are doing a dispatchSync in LocalSampleBufferDisplayLayer destructor.

Ah, sneaky :) Seems safe indeed then. Sorry about the noise.