[webkit-reviews] review granted: [Bug 220839] [WebAuthn] No error is visible after user enters the incorrect PIN : [Attachment 418104] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 220839: [WebAuthn] No error is visible after user enters the incorrect PIN
https://bugs.webkit.org/show_bug.cgi?id=220839

Attachment 418104: Patch

https://bugs.webkit.org/attachment.cgi?id=418104&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418104
  --> https://bugs.webkit.org/attachment.cgi?id=418104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418104&action=review

r=me

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinat
or.mm:159
> +    if (m_presentedPIN)

You might want to add a logging message so we can debug failed PIN cases in the
future.