[webkit-reviews] review granted: [Bug 220867] DisplayList::Replayer should stop replay and inform clients after encountering an invalid item : [Attachment 418157] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 11:58:00 PST 2021


Chris Dumez <cdumez at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 220867: DisplayList::Replayer should stop replay and inform clients after
encountering an invalid item
https://bugs.webkit.org/show_bug.cgi?id=220867

Attachment 418157: Patch

https://bugs.webkit.org/attachment.cgi?id=418157&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 418157
  --> https://bugs.webkit.org/attachment.cgi?id=418157
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418157&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayList.h:129
> +		   m_isValid ? Optional<ItemHandle> {{ m_currentBufferForItem
}} : WTF::nullopt,

nit: makeOptional() may look nicer.

> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:42
> +static constexpr CGFloat contextWidth = 100;

static is not needed since global & const.

> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:43
> +static constexpr CGFloat contextHeight = 100;

ditto.


More information about the webkit-reviews mailing list