[webkit-reviews] review granted: [Bug 220758] Accelerate HTMLInputElement creation : [Attachment 417937] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 220758: Accelerate HTMLInputElement creation
https://bugs.webkit.org/show_bug.cgi?id=220758

Attachment 417937: Patch

https://bugs.webkit.org/attachment.cgi?id=417937&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 417937
  --> https://bugs.webkit.org/attachment.cgi?id=417937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417937&action=review

> Source/WebCore/html/InputType.h:337
> +    explicit InputType(HTMLInputElement& element, Type type)

I'd prefer to see Type be the first argument to this constructor and all the
derived class constructors.

> Source/WebCore/html/InputType.h:350
> +    Type m_type;

This can be const.