[webkit-reviews] review granted: [Bug 219139] Support WEBGL_multi_draw extension : [Attachment 417930] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 219139: Support WEBGL_multi_draw extension
https://bugs.webkit.org/show_bug.cgi?id=219139

Attachment 417930: Patch

https://bugs.webkit.org/attachment.cgi?id=417930&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 417930
  --> https://bugs.webkit.org/attachment.cgi?id=417930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417930&action=review

> Source/WebCore/html/canvas/WebGLMultiDraw.cpp:92
> +void WebGLMultiDraw::multiDrawArraysInstancedWEBGL(
> +    GCGLenum mode,
> +    Int32List firstsList,
> +    GCGLuint firstsOffset,
> +    Int32List countsList,
> +    GCGLuint countsOffset,
> +    Int32List instanceCountsList,
> +    GCGLuint instanceCountsOffset,
> +    GCGLsizei drawcount)
> +{

Nit: We do parameters on one line (same for elsewhere in the patch)

> Source/WebCore/html/canvas/WebGLMultiDraw.h:39
> +	   using VariantType = Variant<RefPtr<TypedArray>, Vector<DataType>>;

Could we give this a better name?

>> Source/WebCore/platform/graphics/ExtensionsGL.h:353
>> +	// GL_ANGLE_multi_draw
> 
> I've been trying to move stuff out of the ExtensionsGL. If it fits your
structure, these could also perhaps be of form
GraphicsContextGL::multiDrawArrays(), etc.

+1