[webkit-reviews] review granted: [Bug 220450] [Win][DumpRenderTree] ASSERT(!m_channel) failed in WebSocket::contextDestroyed : [Attachment 417785] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 220450: [Win][DumpRenderTree] ASSERT(!m_channel) failed in
WebSocket::contextDestroyed
https://bugs.webkit.org/show_bug.cgi?id=220450

Attachment 417785: Patch

https://bugs.webkit.org/attachment.cgi?id=417785&action=review




--- Comment #29 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 417785
  --> https://bugs.webkit.org/attachment.cgi?id=417785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417785&action=review

R=me. It does not look like this patch adds additional flakiness, but it would
be great if you could keep an eye on EWS after landing to make sure �� It
usually takes a few EWS iterations to detect new flakiness.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1298
> +	       PostQuitMessage(0);

Is it ok to call this function multiple times during the lifetime of the
process?