[webkit-reviews] review granted: [Bug 220712] Object.assign should always throw if `target` is non-extensible : [Attachment 417838] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 220712: Object.assign should always throw if `target` is non-extensible
https://bugs.webkit.org/show_bug.cgi?id=220712

Attachment 417838: Patch

https://bugs.webkit.org/attachment.cgi?id=417838&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 417838
  --> https://bugs.webkit.org/attachment.cgi?id=417838
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417838&action=review

r=me with comments

> Source/JavaScriptCore/ChangeLog:3
> +	   Object.assign should always throw if `target` is non-extensible

Seems like "always" is a bit too strong if we don't throw when updating a
property, right?

> Source/JavaScriptCore/ChangeLog:12
> +	   Aligns JSC with the spec [1], V8, and SpiderMonkey.

Should we add a test262 test too?