[webkit-reviews] review granted: [Bug 220381] Use sendWithAsyncReply instead of dataCallback for icon loading : [Attachment 417139] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 220381: Use sendWithAsyncReply instead of dataCallback for icon loading
https://bugs.webkit.org/show_bug.cgi?id=220381

Attachment 417139: Patch

https://bugs.webkit.org/attachment.cgi?id=417139&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 417139
  --> https://bugs.webkit.org/attachment.cgi?id=417139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417139&action=review

> Source/WebCore/loader/DocumentLoader.cpp:327
> +	   callback(nullptr);

Can callback modify m_iconLoaders?
Given we do m_iconLoaders.clear() below, can we do a std::exchange?

> Source/WebCore/loader/DocumentLoader.cpp:2193
> +    m_iconLoaders.set(WTFMove(iconLoader), WTFMove(completionHandler));

s/set/add/