[webkit-reviews] review granted: [Bug 220482] Crash at SOAuthorizationSession::dismissViewController : [Attachment 417304] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 220482: Crash at SOAuthorizationSession::dismissViewController
https://bugs.webkit.org/show_bug.cgi?id=220482

Attachment 417304: Patch

https://bugs.webkit.org/attachment.cgi?id=417304&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 417304
  --> https://bugs.webkit.org/attachment.cgi?id=417304
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417304&action=review

> Source/WebKit/ChangeLog:16
> +	   chooses the latter.

Or SOAuthorizationSession::dismissViewController() is called from a background
thread.

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:305
> +	       m_presentingWindowDidDeminiaturizeObserver =
[[NSNotificationCenter defaultCenter]
addObserverForName:NSWindowDidDeminiaturizeNotification object:presentingWindow
queue:nil usingBlock:[weakThis = makeRefPtr(this), this] (NSNotification *) {

Should be weakThis = makeWeakPtr(this) probably.

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:321
> +	   m_applicationDidUnhideObserver = [[NSNotificationCenter
defaultCenter] addObserverForName:NSApplicationDidUnhideNotification
object:NSApp queue:nil usingBlock:[weakThis = makeRefPtr(this), this]
(NSNotification *) {

Ditto