[webkit-reviews] review granted: [Bug 220143] Take aspect-ratio into account for percentage resolution : [Attachment 417203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 14:13:54 PST 2021

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 220143: Take aspect-ratio into account for percentage resolution

Attachment 417203: Patch


--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 417203
  --> https://bugs.webkit.org/attachment.cgi?id=417203

View in context: https://bugs.webkit.org/attachment.cgi?id=417203&action=review

> Source/WebCore/rendering/RenderBox.cpp:3310
> +	   return blockSizeFromAspectRatio(horizontalBorderAndPaddingExtent(),
verticalBorderAndPaddingExtent(), style().logicalAspectRatio() ,
style().boxSizing(), logicalWidth());

Stray space here before a ",".

> Source/WebCore/rendering/RenderBox.h:704
> +    static LayoutUnit blockSizeFromAspectRatio(LayoutUnit
borderPaddingInlineSum, LayoutUnit borderPaddingBlockSum, double aspectRatio,
BoxSizing boxSizing, LayoutUnit inlineSize)

Since all paths convert aspectRatio into LayoutUnit, could we take the argument
as a LayoutUnit instead of converting inside the function?

More information about the webkit-reviews mailing list