[webkit-reviews] review granted: [Bug 220423] [Mac] Add runtime logging to format reader and WebM parser : [Attachment 417208] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 14:13:18 PST 2021


Andy Estes <aestes at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 220423: [Mac] Add runtime logging to format reader and WebM parser
https://bugs.webkit.org/show_bug.cgi?id=220423

Attachment 417208: Patch

https://bugs.webkit.org/attachment.cgi?id=417208&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 417208
  --> https://bugs.webkit.org/attachment.cgi?id=417208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417208&action=review

> Source/WebKit/Shared/mac/MediaFormatReader/MediaTrackReader.cpp:78
> +    , m_logIdentifier(formatReader.nextTrackReaderLogIdentifier())

Can trackID also be the log identifier here?


More information about the webkit-reviews mailing list