[webkit-reviews] review granted: [Bug 222110] color(lab ...) should serialize as color(lab ...) not lab() according to latest CSS Color 4 spec : [Attachment 420911] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 222110: color(lab ...) should serialize as color(lab ...) not lab()
according to latest CSS Color 4 spec
https://bugs.webkit.org/show_bug.cgi?id=222110

Attachment 420911: Patch

https://bugs.webkit.org/attachment.cgi?id=420911&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 420911
  --> https://bugs.webkit.org/attachment.cgi?id=420911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420911&action=review

> Source/WebCore/platform/graphics/Color.cpp:129
> +	       auto result = colorWithOverridenAlpha(underlyingColor, alpha);

Not new in this patch, but there is a typo in Overridden.

> Source/WebCore/platform/graphics/Color.h:198
> +    enum class AllFlags {

It is common to have this All* enum? I would have thought you call this one
Flags and the earlier one FlagsSubset or something?