[webkit-reviews] review canceled: [Bug 222006] Web Inspector: Implement Grid Overlay "Show line names" drawing : [Attachment 420903] WIP v0.1 - Auto-repeat and implicit names not working

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 04:23:59 PST 2021


Patrick Angle <pangle at apple.com> has canceled Patrick Angle
<pangle at apple.com>'s request for review:
Bug 222006: Web Inspector: Implement Grid Overlay "Show line names" drawing
https://bugs.webkit.org/show_bug.cgi?id=222006

Attachment 420903: WIP v0.1 - Auto-repeat and implicit names not working

https://bugs.webkit.org/attachment.cgi?id=420903&action=review




--- Comment #4 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 420903
  --> https://bugs.webkit.org/attachment.cgi?id=420903
WIP v0.1 - Auto-repeat and implicit names not working

View in context: https://bugs.webkit.org/attachment.cgi?id=420903&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:1340
> +    auto orderedGridLineNames = direction ==
GridTrackSizingDirection::ForColumns ?
renderStyle->orderedNamedGridColumnLines() :
renderStyle->orderedNamedGridRowLines();

A breadcrumb for future me: I think I need to copy these values, not reference
them, otherwise I’m actually adding the other grid line name maps to this map.


More information about the webkit-reviews mailing list