[webkit-reviews] review granted: [Bug 222014] Change App Highlight delegate to pass more information about the highlight for display. : [Attachment 420586] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 16 20:35:53 PST 2021
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222014: Change App Highlight delegate to pass more information about the
highlight for display.
https://bugs.webkit.org/show_bug.cgi?id=222014
Attachment 420586: Patch
https://bugs.webkit.org/attachment.cgi?id=420586&action=review
--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420586
--> https://bugs.webkit.org/attachment.cgi?id=420586
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=420586&action=review
> Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlight.mm:39
> + _text = text;
Where'd the image go
> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:29
> +
Too many newlines
More information about the webkit-reviews
mailing list