[webkit-reviews] review granted: [Bug 222022] [iOS] Add support for additional accessibility image extraction contextmenu actions : [Attachment 420584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 20:45:25 PST 2021


Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 222022: [iOS] Add support for additional accessibility image extraction
contextmenu actions
https://bugs.webkit.org/show_bug.cgi?id=222022

Attachment 420584: Patch

https://bugs.webkit.org/attachment.cgi?id=420584&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420584
  --> https://bugs.webkit.org/attachment.cgi?id=420584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420584&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9718
> +static NSMutableArray<UIMenuElement *> *menuElementsFromDefaultActions(const
RetainPtr<NSArray>& defaultElementActions, RetainPtr<_WKActivatedElementInfo>
elementInfo)

For some reason I can't expand the context, is the return value really already
a mutable array? (since you only change the type here)


More information about the webkit-reviews mailing list