[webkit-reviews] review granted: [Bug 221668] [JSC] Simplify excludedSet handling in object rest expression : [Attachment 420219] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 221668: [JSC] Simplify excludedSet handling in object rest expression
https://bugs.webkit.org/show_bug.cgi?id=221668

Attachment 420219: Patch

https://bugs.webkit.org/attachment.cgi?id=420219&action=review




--- Comment #11 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 420219
  --> https://bugs.webkit.org/attachment.cgi?id=420219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420219&action=review

This is a thing of beauty, r=me.

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:5616
> +    CallArguments args(generator, nullptr, 1);

-1 bytecode op, nice.

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:875
> +		   auto propertyName =
callFrame->uncheckedArgument(index).toPropertyKey(globalObject);

nit: Can we have a comment saying "this isn't observable since
ObjectPatternNode::bindValue() also performs ToPropertyKey"?

> JSTests/ChangeLog:8
> +	   * microbenchmarks/object-rest-computed-destructuring.js: Added.

nit: Stating microbenchmark progression would be nice for future ChangeLog
readers.