[webkit-reviews] review granted: [Bug 221922] REGRESSION r272823): Crash in ARM64e Wasm tests : [Attachment 420380] Updated patch after offline discussion with Mark Lam
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 15 15:04:02 PST 2021
Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 221922: REGRESSION r272823): Crash in ARM64e Wasm tests
https://bugs.webkit.org/show_bug.cgi?id=221922
Attachment 420380: Updated patch after offline discussion with Mark Lam
https://bugs.webkit.org/attachment.cgi?id=420380&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 420380
--> https://bugs.webkit.org/attachment.cgi?id=420380
Updated patch after offline discussion with Mark Lam
View in context: https://bugs.webkit.org/attachment.cgi?id=420380&action=review
r=me
> Source/WTF/wtf/threads/Signals.cpp:219
> - ptrauth_generic_signature_t inStateHash = hashThreadState(inState);
> + ptrauth_generic_signature_t inThreadStateHash =
hashThreadState(inState);
nit: I thought that `inStateHash` was a good name because it's a "hash of the
inState". But this is fine too.
More information about the webkit-reviews
mailing list