[webkit-reviews] review granted: [Bug 221623] [WebAuthn] Produce ClientDataJSON in the SPI : [Attachment 419758] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 221623: [WebAuthn] Produce ClientDataJSON in the SPI
https://bugs.webkit.org/show_bug.cgi?id=221623

Attachment 419758: Patch

https://bugs.webkit.org/attachment.cgi?id=419758&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 419758
  --> https://bugs.webkit.org/attachment.cgi?id=419758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419758&action=review

r=me, but please fix the unused function warning.

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:55
> +

These two method should be inside #if ENABLE(WEB_AUTHN)