[webkit-reviews] review granted: [Bug 221706] [PlayStation] Add initial RESOURCE_USAGE implementation : [Attachment 419896] patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 221706: [PlayStation] Add initial RESOURCE_USAGE implementation
https://bugs.webkit.org/show_bug.cgi?id=221706

Attachment 419896: patch

https://bugs.webkit.org/attachment.cgi?id=419896&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 419896
  --> https://bugs.webkit.org/attachment.cgi?id=419896
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419896&action=review

r=me, seems fine as a stub.

> Source/WebCore/page/playstation/ResourceUsageThreadPlayStation.cpp:38
> +    // FIXME: Need a way to calculate cpu usage

Technically we should create a bug for these FIXMEs and link to it, but since
this is a stub and you're just describing what needs to be done instead of the
stub, I'm not terribly concerned about it.