[webkit-reviews] review granted: [Bug 234671] [LFC][IFC] ContinuousContent should tell InlineContentBreaker if the candidate content is hanging : [Attachment 447952] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234671: [LFC][IFC] ContinuousContent should tell InlineContentBreaker if
the candidate content is hanging
https://bugs.webkit.org/show_bug.cgi?id=234671

Attachment 447952: Patch

https://bugs.webkit.org/attachment.cgi?id=447952&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 447952
  --> https://bugs.webkit.org/attachment.cgi?id=447952
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447952&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:207
> +	   auto hangingContentWidth = [&]() -> std::optional<InlineLayoutUnit>
{
> +	       return isWhitespace && style.whiteSpace() == WhiteSpace::PreWrap
? std::make_optional(logicalWidth) : std::nullopt;
> +	   };

maybe not to most necessary lambda