[webkit-reviews] review granted: [Bug 234676] [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's leading/trailing member variables to std::optional<InlineLayoutUnit> : [Attachment 447950] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 25 01:32:55 PST 2021
Antti Koivisto <koivisto at iki.fi> has granted review:
Bug 234676: [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's
leading/trailing member variables to std::optional<InlineLayoutUnit>
https://bugs.webkit.org/show_bug.cgi?id=234676
Attachment 447950: Patch
https://bugs.webkit.org/attachment.cgi?id=447950&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 447950
--> https://bugs.webkit.org/attachment.cgi?id=447950
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447950&action=review
> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:516
> - auto avilableWidth = std::max(0.0f, lineStatus.availableWidth -
nonOverflowingContentWidth);
> + auto avilableWidth = std::max(0.f, lineStatus.availableWidth -
nonOverflowingContentWidth);
"avilable"
> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:539
> - auto avilableWidth = std::max(0.0f, lineStatus.availableWidth -
previousContentWidth);
> + auto avilableWidth = std::max(0.f, lineStatus.availableWidth -
previousContentWidth);
here too
More information about the webkit-reviews
mailing list