[webkit-reviews] review granted: [Bug 234369] Move ownership of the WheelEventDeltaFilter from EventHandler to ThreadedScrollingTree : [Attachment 447291] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 234369: Move ownership of the WheelEventDeltaFilter from EventHandler to
ThreadedScrollingTree
https://bugs.webkit.org/show_bug.cgi?id=234369

Attachment 447291: Patch

https://bugs.webkit.org/attachment.cgi?id=447291&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 447291
  --> https://bugs.webkit.org/attachment.cgi?id=447291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447291&action=review

> Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:118
> +#if PLATFORM(COCOA)
> +	   platformWheelEvent =
scrollingTree->wheelEventAfterFiltering(platformWheelEvent);
> +#endif

Can we have all platforms implement wheelEventAfterFiltering() (or the base
class) as the identity function if they don't need to do any filtering to
remove this #ifdef?