[webkit-reviews] review granted: [Bug 234367] Use arm64's fmax/fmin instructions in Wasm : [Attachment 447383] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 16 12:41:59 PST 2021

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 234367: Use arm64's fmax/fmin instructions in Wasm

Attachment 447383: patch


--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 447383
  --> https://bugs.webkit.org/attachment.cgi?id=447383

View in context: https://bugs.webkit.org/attachment.cgi?id=447383&action=review

R=me with nit

> Source/JavaScriptCore/b3/B3Common.h:163
> +	   return a + b;

nit: Why not just return PNaN? This makes me think I forgot how adding nans
work lol.

More information about the webkit-reviews mailing list