[webkit-reviews] review granted: [Bug 234235] [LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObject : [Attachment 446990] Patch, v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 06:27:43 PST 2021
Rob Buis <rbuis at igalia.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 234235: [LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObject
https://bugs.webkit.org/show_bug.cgi?id=234235
Attachment 446990: Patch, v1
https://bugs.webkit.org/attachment.cgi?id=446990&action=review
--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 446990
--> https://bugs.webkit.org/attachment.cgi?id=446990
Patch, v1
View in context: https://bugs.webkit.org/attachment.cgi?id=446990&action=review
> Source/WebCore/rendering/RenderObject.h:351
> + bool isRenderSVGModelObjectOrLegacyRenderSVGModelObject() const { return
isRenderSVGModelObject() || isLegacyRenderSVGModelObject(); }
Not too fond of the length. isARenderSVGModelObject?
isRenderSVGModelObjectLike?
More information about the webkit-reviews
mailing list