[webkit-reviews] review granted: [Bug 234239] [GTK] build fails with undefined symbol in ANGLE if USE_ANGLE_WEBGL is enabled. : [Attachment 446992] Patch

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has granted Arcady Goldmints-Orlov
<agoldmints at igalia.com>'s request for review:
Bug 234239: [GTK] build fails with undefined symbol in ANGLE if USE_ANGLE_WEBGL
is enabled.
https://bugs.webkit.org/show_bug.cgi?id=234239

Attachment 446992: Patch

https://bugs.webkit.org/attachment.cgi?id=446992&action=review




--- Comment #3 from Chris Lord <clord at igalia.com> ---
Comment on attachment 446992
  --> https://bugs.webkit.org/attachment.cgi?id=446992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446992&action=review

LGTM, with one noted change.

> Source/ThirdParty/ANGLE/GL.cmake:237
> +if (is_android OR is_linux OR is_chromeos)
> +    list(APPEND _gl_backend_sources
> +	   "src/common/linux/dma_buf_utils.cpp"
> +	   "src/common/linux/dma_buf_utils.h"
> +    )
> +endif()

Why not add these to the existing block at line 127?