[webkit-reviews] review granted: [Bug 234052] Use thread safe initialization in rotateLeftTransform : [Attachment 446494] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 15:16:49 PST 2021


Myles C. Maxfield <mmaxfield at apple.com> has granted  review:
Bug 234052: Use thread safe initialization in rotateLeftTransform
https://bugs.webkit.org/show_bug.cgi?id=234052

Attachment 446494: Patch

https://bugs.webkit.org/attachment.cgi?id=446494&action=review




--- Comment #8 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446494
  --> https://bugs.webkit.org/attachment.cgi?id=446494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446494&action=review

Feels a bit weird that the patch title only is relevant to like 1/2 of this
patch.

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:57
> +static constexpr AffineTransform rotateLeftTransform { 0, -1, 1, 0, 0, 0 };

��

> Tools/ChangeLog:3
> +	   Remove unused AffineTransform variable from a test

Are you sure you meant to include this in this patch?


More information about the webkit-reviews mailing list