[webkit-reviews] review granted: [Bug 234024] [GPU Process] [Filters] Add the encoding and decoding for SVGFilter : [Attachment 446409] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 234024: [GPU Process] [Filters] Add the encoding and decoding for SVGFilter
https://bugs.webkit.org/show_bug.cgi?id=234024

Attachment 446409: Patch

https://bugs.webkit.org/attachment.cgi?id=446409&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 446409
  --> https://bugs.webkit.org/attachment.cgi?id=446409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446409&action=review

> Source/WebKit/Platform/IPC/FilterReference.h:334
> +    auto expressionReference = WTF::map(filter.expression(), [&indecies]
(auto&& term) -> ExpressionReferenceTerm {

Nit - sp. indecies => indicies

> Source/WebKit/Platform/IPC/FilterReference.h:383
> +    WebCore::SVGFilterExpression expression;

Nit - maybe reserveInitialCapacity here?