[webkit-reviews] review granted: [Bug 233087] CSP: Implement protections against nonce-hijacking : [Attachment 444244] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 233087: CSP: Implement protections against nonce-hijacking
https://bugs.webkit.org/show_bug.cgi?id=233087

Attachment 444244: Patch

https://bugs.webkit.org/attachment.cgi?id=444244&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 444244
  --> https://bugs.webkit.org/attachment.cgi?id=444244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444244&action=review

r=me

> Source/WebCore/dom/Element.cpp:334
> +	       const auto& name = attribute.localName();

If you did "localName().convertToASCIILowercase()", you could do the following
four string comparisons without doing case insensitive compares.

> Source/WebCore/dom/Element.cpp:335
> +	       const auto& value = attribute.value();

Ditto for value