[webkit-reviews] review denied: [Bug 233949] [GStreamer] Be noisy on stderr and bail out early on missing required elements : [Attachment 446228] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 233949: [GStreamer] Be noisy on stderr and bail out early on missing
required elements
https://bugs.webkit.org/show_bug.cgi?id=233949

Attachment 446228: Patch

https://bugs.webkit.org/attachment.cgi?id=446228&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 446228
  --> https://bugs.webkit.org/attachment.cgi?id=446228
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446228&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:512
> -    RELEASE_ASSERT_WITH_MESSAGE(element, "GStreamer element %s not found.
Please install it", factoryName);
> +    if (!element) {
> +	   RELEASE_ASSERT_WITH_MESSAGE(false, "GStreamer element %s (factory
%s) not found. Please install it", name, factoryName);
> +	   WTFLogAlways("Required GStreamer element %s (factory %s) not found.
Please install it", name, factoryName);
> +	   WTFCrash();
> +    }

Adrian your new code is unreachable. RELEASE_ASSERT() does not return!