[webkit-reviews] review granted: [Bug 233750] remove expandAroundIdeographs static variables : [Attachment 445678] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 233750: remove expandAroundIdeographs static variables
https://bugs.webkit.org/show_bug.cgi?id=233750

Attachment 445678: Patch

https://bugs.webkit.org/attachment.cgi?id=445678&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 445678
  --> https://bugs.webkit.org/attachment.cgi?id=445678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445678&action=review

> Source/WebCore/ChangeLog:18
> +	   canExpandAroundIdeographsInComplexText is a simple enough function
in
> +	   all ports (it just returns a constant bool) that it's not worth
caching
> +	   the result in a static.

Can we make the function constexpr?

Do you know why the other ports can't expand around ideographs? Expanding
around ideographs is a property of written language, not a property of which OS
you're running on.