[webkit-reviews] review granted: [Bug 233749] move shouldAutoActivateFontIfNeeded knownFamilies cache to FontCache : [Attachment 445676] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 233749: move shouldAutoActivateFontIfNeeded knownFamilies cache to
FontCache
https://bugs.webkit.org/show_bug.cgi?id=233749

Attachment 445676: Patch

https://bugs.webkit.org/attachment.cgi?id=445676&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 445676
  --> https://bugs.webkit.org/attachment.cgi?id=445676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445676&action=review

Good idea.

> Source/WebCore/platform/graphics/FontCache.h:378
> +#if PLATFORM(MAC)

I think generally our policy is to only ifdef function definitions, not
declarations (just to reduce visual noise).