[webkit-reviews] review denied: [Bug 229339] Add stubs for Permissions API : [Attachment 436664] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 229339: Add stubs for Permissions API
https://bugs.webkit.org/show_bug.cgi?id=229339

Attachment 436664: Patch

https://bugs.webkit.org/attachment.cgi?id=436664&action=review




--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 436664
  --> https://bugs.webkit.org/attachment.cgi?id=436664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436664&action=review

> Source/WebCore/Modules/permissions/PermissionStatus.cpp:67
> +void PermissionStatus::stateChanged(PermissionState newState)
> +{
> +    if (m_state != newState)
> +	   queueTaskToDispatchEvent(*this, TaskSource::Permission,
Event::create(eventNames().changeEvent, Event::CanBubble::No,
Event::IsCancelable::No));
> +}

This event dispatching mechanism isn't sound from GC perspective.
We don't have anything in place to keep the JS wrapper of PermissionStatus
alive until this function is called.