[webkit-reviews] review granted: [Bug 229622] Rename enums in CSSUnitType to CamelCase and remove CSS_ prefix : [Attachment 436675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 14:35:54 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kiet Ho
<tho22 at apple.com>'s request for review:
Bug 229622: Rename enums in CSSUnitType to CamelCase and remove CSS_ prefix
https://bugs.webkit.org/show_bug.cgi?id=229622

Attachment 436675: Patch

https://bugs.webkit.org/attachment.cgi?id=436675&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 436675
  --> https://bugs.webkit.org/attachment.cgi?id=436675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436675&action=review

> Source/WebCore/css/CSSUnits.h:64
> +    DotsPerInch = 31,
> +    DotsPerCentimeter = 32,

We use Cm and In above so these should be DotsPerCm and DotsPerIn


More information about the webkit-reviews mailing list