[webkit-reviews] review granted: [Bug 228773] [macOS] Update message filters : [Attachment 434903] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 228773: [macOS] Update message filters
https://bugs.webkit.org/show_bug.cgi?id=228773

Attachment 434903: Patch

https://bugs.webkit.org/attachment.cgi?id=434903&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 434903
  --> https://bugs.webkit.org/attachment.cgi?id=434903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434903&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:269
> +	   (deny (with telemetry) (with message
"IOMobileFramebufferUserClient")

So we deny (with telemetry) pretty much all uses of
iokit-async-external-method, and iokit-external-trap ...

>>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273
>>> +	     (allow (with telemetry-backtrace) iokit-external-method
>> 
>> Do we really want telemetry-backtrace on these two methods?
> 
> Yes, I believe so. They are not expected to be frequently used.
> 
> Thanks for reviewing!

... and allow with backtrace iokit-external-method for these two methods.

That means everything else is denied without telemetry, right?

If so, I think this seems right.