[webkit-reviews] review granted: [Bug 228774] [iOS 15] "Look Up" action is sometimes missing after force pressing images : [Attachment 434905] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 10:54:21 PDT 2021


Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 228774: [iOS 15] "Look Up" action is sometimes missing after force pressing
images
https://bugs.webkit.org/show_bug.cgi?id=228774

Attachment 434905: Patch

https://bugs.webkit.org/attachment.cgi?id=434905&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 434905
  --> https://bugs.webkit.org/attachment.cgi?id=434905
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434905&action=review

r=me

> Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm:68
> +    if (touches.anyObject.force < forceThreshold)

Is every `UITouch` guaranteed to have the same `force`?  Or do we need to
iterate this?


More information about the webkit-reviews mailing list