[webkit-reviews] review granted: [Bug 225007] Reduce memory footprint for background tabs : [Attachment 427084] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 26 13:39:45 PDT 2021
Chris Dumez <cdumez at apple.com> has granted review:
Bug 225007: Reduce memory footprint for background tabs
https://bugs.webkit.org/show_bug.cgi?id=225007
Attachment 427084: Patch
https://bugs.webkit.org/attachment.cgi?id=427084&action=review
--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427084
--> https://bugs.webkit.org/attachment.cgi?id=427084
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=427084&action=review
r=me with nits.
>> Source/WebKit/WebProcess/WebProcess.cpp:1600
>> + WebCore::releaseMemory(WTF::Critical::Yes, WTF::Synchronous::No,
WebCore::MaintainBackForwardCache::Yes, WebCore::MaintainMemoryCache::No);
>
> You are still clearing the back/forward cache, which is the one I complained
about.
>
> WTF:: is unnecessary, so is WebCore::.
Oh, I misread, this is keeping the back/forward cache. My bad.
More information about the webkit-reviews
mailing list