[webkit-reviews] review denied: [Bug 225007] Reduce memory footprint for background tabs : [Attachment 427084] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Ben Nham <nham at apple.com>'s request
for review:
Bug 225007: Reduce memory footprint for background tabs
https://bugs.webkit.org/show_bug.cgi?id=225007

Attachment 427084: Patch

https://bugs.webkit.org/attachment.cgi?id=427084&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427084
  --> https://bugs.webkit.org/attachment.cgi?id=427084
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427084&action=review

r- because this clears the back/forward cache and thus likely breaks the
back/forward cache after 1 min, after navigating cross-origin (process-swap).

> Source/WebKit/WebProcess/WebProcess.cpp:1600
> +    WebCore::releaseMemory(WTF::Critical::Yes, WTF::Synchronous::No,
WebCore::MaintainBackForwardCache::Yes, WebCore::MaintainMemoryCache::No);

You are still clearing the back/forward cache, which is the one I complained
about.

WTF:: is unnecessary, so is WebCore::.

> Source/WebKit/WebProcess/WebProcess.cpp:1602
> +	   page->releaseMemory(WTF::Critical::Yes);

WTF:: is unnecessary.