[webkit-reviews] review granted: [Bug 224045] Pass the main frame URL to requestGeolocationAuthorizationForURL delegate SPI : [Attachment 426468] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224045: Pass the main frame URL to requestGeolocationAuthorizationForURL
delegate SPI
https://bugs.webkit.org/show_bug.cgi?id=224045

Attachment 426468: Patch

https://bugs.webkit.org/attachment.cgi?id=426468&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 426468
  --> https://bugs.webkit.org/attachment.cgi?id=426468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426468&action=review

> Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm:200
> -    auto policyListener = adoptNS([[WKWebAllowDenyPolicyListener alloc]
initWithCompletionHandler:WTFMove(request.completionHandler)]);
> +    auto policyListener = adoptNS([[WKWebAllowDenyPolicyListener alloc]
initWithCompletionHandler:WTFMove(decisionHandler)]);

This does more than just fix a use-after-move.

It also adds a call to the geolocationAuthorizationGranted method, which I hope
is also a progression.

Is there a way we can construct a test that is sensitive to both of these?