[webkit-reviews] review granted: [Bug 224399] webaudio/AudioListener/audiolistener-set-position.html is leaking PannerNodes : [Attachment 425774] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224399: webaudio/AudioListener/audiolistener-set-position.html is leaking
PannerNodes
https://bugs.webkit.org/show_bug.cgi?id=224399

Attachment 425774: Patch

https://bugs.webkit.org/attachment.cgi?id=425774&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 425774
  --> https://bugs.webkit.org/attachment.cgi?id=425774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425774&action=review

r=me

> Source/WebCore/ChangeLog:33
> +	   Early return if lazyInitialize() gets called for au audiocontext is
closed. Nothing prevents JS from

for au => after an

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:184
> +bool AudioScheduledSourceNode::virtualHasPendingActivity() const

Not for this patch, but this function really needs a better to name to clarify
that it is an addition, *not* an override.

Maybe "hasAdditionalPendingActivity" or something like that.