[webkit-reviews] review denied: [Bug 224422] REGRESSION(r275262) [WebDriver] Make automation JS code aware of injected script headers : [Attachment 425718] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 13:50:00 PDT 2021


BJ Burg <bburg at apple.com> has denied Lauro Moura <lmoura at igalia.com>'s request
for review:
Bug 224422: REGRESSION(r275262) [WebDriver] Make automation JS code aware of
injected script headers
https://bugs.webkit.org/show_bug.cgi?id=224422

Attachment 425718: Patch

https://bugs.webkit.org/attachment.cgi?id=425718&action=review




--- Comment #4 from BJ Burg <bburg at apple.com> ---
Comment on attachment 425718
  --> https://bugs.webkit.org/attachment.cgi?id=425718
Patch

the //# directive is a source map directive. It labels these evaluations, which
is essential when debugging WebAutomationSessionProxy code via Web Inspector.

Perhaps you could search for the first non-comment line and wrap the remainder
of the evaluation there, lifting any initial comments outside the async
statement.


More information about the webkit-reviews mailing list