[webkit-reviews] review granted: [Bug 224386] Consistently include JavaScriptCore's Inspector private interface headers : [Attachment 425676] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224386: Consistently include JavaScriptCore's Inspector private interface
headers
https://bugs.webkit.org/show_bug.cgi?id=224386

Attachment 425676: Patch

https://bugs.webkit.org/attachment.cgi?id=425676&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 425676
  --> https://bugs.webkit.org/attachment.cgi?id=425676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425676&action=review

>
Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-s
etters.json-result:1005
> +    Optional<TestProtocolRuntimeKeyPathType> type =
fromProtocolString<TestProtocolRuntimeKeyPathType>((__bridge
CFStringRef)payload[@"type"]);

What caused this change? Maybe someone forgot to regenerate these expected
results and we’re not running this test?