[webkit-reviews] review granted: [Bug 224391] Deprecate and remove most of _WKUserContentFilter : [Attachment 425677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 10 11:59:57 PDT 2021


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224391: Deprecate and remove most of _WKUserContentFilter
https://bugs.webkit.org/show_bug.cgi?id=224391

Attachment 425677: Patch

https://bugs.webkit.org/attachment.cgi?id=425677&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 425677
  --> https://bugs.webkit.org/attachment.cgi?id=425677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425677&action=review

There seems to be an InstallAPI issue with the classes that are removed on iOS
that needs to be addressed somehow. r=me assuming that’s worked out

> Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:31
> +IGNORE_WARNINGS_BEGIN("deprecated-implementations")

Kind of surprised we don’t have a separate named macro for this one.

> Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:35
> +- (id)_initWithWKContentRuleList:(WKContentRuleList *)contentRuleList

Not sure exactly how stubby to leave these stub classes. Could imagine also
overriding init to return nil like this.

> Source/WebKit/UIProcess/API/Cocoa/_WKUserContentFilter.mm:37
> +    return nil;

We ought to release or dealloc self before returning nil.


More information about the webkit-reviews mailing list