[webkit-reviews] review granted: [Bug 216933] Pause is needed while simulating mouse actions : [Attachment 409713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 26 16:03:09 PDT 2020

Darin Adler <darin at apple.com> has granted cathiechen <cathiechen at igalia.com>'s
request for review:
Bug 216933: Pause is needed while simulating mouse actions

Attachment 409713: Patch


--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 409713
  --> https://bugs.webkit.org/attachment.cgi?id=409713

View in context: https://bugs.webkit.org/attachment.cgi?id=409713&action=review

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:10
> +// Provide an imprecise way of pause.

This comment is not grammatically correct and it’s also unclear. I suppose it’s
saying that there is something wrong with the implementation, but what? I
suggest omitting the comment, or we could include it if we can pinpoint *what*
we are trying to say and find a good way to word it.

Is there something wrong with using setTimeout to pause? If so, what is it? Is
there a problem with precision of the duration? Or is the problem that a
timeout is queued behind other operations or on the wrong run loop? Maybe there
is nothing wrong!

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:50
> +		       // FIXME: Provide a precise way of pause.

Same thing here. Please just remove this comment or if you like I can try to
help write one for whatever we mean here.

More information about the webkit-reviews mailing list