[webkit-reviews] review granted: [Bug 217002] Remove support for setting CMYKA fill and stroke colors in 2D canvas : [Attachment 409791] Rebaseline more tests

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 217002: Remove support for setting CMYKA fill and stroke colors in 2D
canvas
https://bugs.webkit.org/show_bug.cgi?id=217002

Attachment 409791: Rebaseline more tests

https://bugs.webkit.org/attachment.cgi?id=409791&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 409791
  --> https://bugs.webkit.org/attachment.cgi?id=409791
Rebaseline more tests

View in context: https://bugs.webkit.org/attachment.cgi?id=409791&action=review

> Source/WebCore/ChangeLog:17
> +	   In lieu of adding new DisplayList items to support setting fill and
stroke colors with CMYKA components,
> +	   we can take this opportunity to just drop support for this canvas
API entirely. Fixes the following tests
> +	   when using the GPU Process to render canvas:

I understand this feature is WebKit-only; WebKit’s canvas was the original and
predates the standard. How did you determine this feature is not used?

> Source/WebCore/html/canvas/CanvasStyle.h:107
> +    return serializationForHTML(WTF::holds_alternative<Color>(m_style) ?
WTF::get<Color>(m_style) : Color());

This should just call get<Color>, no need to call holds_alternative<>. The
function had a precondition before that it m_style needed to be either Color or
CMYKAColor, and it would assert if that was not so. No reason we have to add
support for the case where it’s neither just because we are removing
CMYKAColor.