[webkit-reviews] review granted: [Bug 216834] [macOS] Issue sandbox extension for the diagnostic daemon : [Attachment 409385] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 216834: [macOS] Issue sandbox extension for the diagnostic daemon
https://bugs.webkit.org/show_bug.cgi?id=216834

Attachment 409385: Patch

https://bugs.webkit.org/attachment.cgi?id=409385&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 409385
  --> https://bugs.webkit.org/attachment.cgi?id=409385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409385&action=review

r=me, but I think you could use an existing FileSystem function instead of the
raw 'stat' operation.

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:68
> +#import <sys/stat.h>

You don't need to include this if you use , FileSystem::fileIsDirectory

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211
> +    static bool isInternal = !stat("/AppleInternal", &st);

I think it might be better to do:

static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal",
FileSystem::ShouldFollowSymbolicLinks::No);