[webkit-reviews] review granted: [Bug 216881] [LFC][IFC] Precompute the collapsible trailing width for LineBreaker : [Attachment 409477] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 23 11:28:20 PDT 2020
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 216881: [LFC][IFC] Precompute the collapsible trailing width for
LineBreaker
https://bugs.webkit.org/show_bug.cgi?id=216881
Attachment 409477: Patch
https://bugs.webkit.org/attachment.cgi?id=409477&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 409477
--> https://bugs.webkit.org/attachment.cgi?id=409477
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=409477&action=review
> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:240
> + if (isFullyCollapsible())
> + m_collapsibleTrailingWidth += logicalWidth;
> + else {
Can this early return avoiding the else branch?
More information about the webkit-reviews
mailing list