[webkit-reviews] review granted: [Bug 198912] [iOS] MediaRecorder incorrect screen orientation handling : [Attachment 409276] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198912: [iOS] MediaRecorder incorrect screen orientation handling
https://bugs.webkit.org/show_bug.cgi?id=198912

Attachment 409276: Patch

https://bugs.webkit.org/attachment.cgi?id=409276&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 409276
  --> https://bugs.webkit.org/attachment.cgi?id=409276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409276&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
430
> +	   if (sample.videoMirrored())
> +	       videoTransform = CGAffineTransformScale(videoTransform, -1, 1);

It would be nice to have internals API to test mirrored mode, like we have
setCameraMediaStreamTrackOrientation to test rotation.