[webkit-reviews] review granted: [Bug 216667] [JSC] BigInt should work with Map / Set : [Attachment 409246] Patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 216667: [JSC] BigInt should work with Map / Set
https://bugs.webkit.org/show_bug.cgi?id=216667

Attachment 409246: Patch

https://bugs.webkit.org/attachment.cgi?id=409246&action=review




--- Comment #7 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 409246
  --> https://bugs.webkit.org/attachment.cgi?id=409246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409246&action=review

r=me, thanks for this patch!

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1384
> +	   SpeculatedType typeMaybeNormalized = (SpecFullNumber &
~SpecInt32Only) | SpecHeapBigInt;

This looks like it is fixing a different bug? Maybe worth mentioning in the
Changelog.

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:520
> +#if USE(BIGINT32)

This is a small unrelated optimization, right? (since doesGC is conservative)