[webkit-reviews] review granted: [Bug 216741] Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node : [Attachment 409221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 19 21:42:06 PDT 2020


Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 216741: Selection API: Fix selectAllChilden to return InvalidNodeTypeError
when passed a DocumentType node
https://bugs.webkit.org/show_bug.cgi?id=216741

Attachment 409221: Patch

https://bugs.webkit.org/attachment.cgi?id=409221&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 409221
  --> https://bugs.webkit.org/attachment.cgi?id=409221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409221&action=review

> Source/WebCore/ChangeLog:8
> +	   This is covered by tests, but the fix itself is only testable when
live range

Can we add a test with <!-- test-runner-options?


More information about the webkit-reviews mailing list